Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate parameter passed to ConfiguratorBase.param() #27694

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Validate parameter passed to ConfiguratorBase.param() #27694

merged 2 commits into from
Sep 9, 2022

Conversation

rdebusscher
Copy link
Contributor

to not to be null. Fixes #27664.

@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Sep 2, 2022
@geoand geoand requested a review from mkouba September 2, 2022 13:06
mkouba
mkouba approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 9, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 9, 2022

Failing Jobs - Building 322e1ba

Status Name Step Failures Logs Raw logs
✖ JVM Tests - JDK 11 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/kafka

📦 integration-tests/kafka

✖ io.quarkus.it.kafka.KafkaProducerTest. - More details - Source on GitHub

java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:714)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptBeforeAllMethod(QuarkusTestExtension.java:769)

@gastaldi gastaldi merged commit 382511f into quarkusio:main Sep 9, 2022
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Sep 9, 2022
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkouba mkouba mkouba approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) kind/enhancement New feature or request triage/flaky-test
Projects
None yet
Milestone
2.13.0.CR1
Development

Successfully merging this pull request may close these issues.

Proper exception message when passing null value to SyntheticBeanBuildItem Configuration parameter
3 participants
@rdebusscher @mkouba @gastaldi